Remove compatiblity shims and allow default pickle override through a setting. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter is pending deprecation since it's an alias of the former on Python 3.
charettes
force-pushed
the
legacy-cleanups
branch
from
ae4a06b to
0cc0a36
Compare
Bumping this value without allowing an override breaks backward compatibility for lookups such as __exact because the string representation of the pickles change.
charettes
force-pushed
the
legacy-cleanups
branch
from
0cc0a36 to
0d84840
Compare
|
@charettes Thanks for the notification! Works for me. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@carltongibson I replaced the
DEFAULT_PROTOCOLbump by a new setting instead as this bump breaks backward compatibility of__exactlookups since the string representation of pickles changes.We could have documented it as a backward incompatible change but I feared some folks might blindly upgrade and end up with a database that is a mix of protocol 2 and 3 pickles which would break
__exactand friends.By introducing this new
PICKLEFIELD_DEFAULT_PROTOCOLsetting it should be possible for users to upgrade to the version they seem for fit for their use case (even > 3) without breaking backward compatibility.